On Thu, May 30, 2019 at 7:21 AM Jeffrey Walton <noloa...@gmail.com> wrote: > > On Thu, May 30, 2019 at 6:49 AM Jeffrey Walton <noloa...@gmail.com> wrote: > > > > On Thu, May 30, 2019 at 6:30 AM Tim Rühsen <tim.rueh...@gmx.de> wrote: > > > > > > Reverted 79be99aff (passes CI). Could you give it try, please ? > > > > Where can we get that? > > > > It is not on the mirror (yet?), and https://www.gnu.org/software/wget/ > > does not list Git or Savannah access. > > I performed a sed on all the *.px files. (If this was wrong let me > know what you need). > > for file in $(find "$PWD" -name '*.px') > do > sed -e 's|env -S perl -I .|env perl|g' "$file" > "$file.fixed" > chmod +w "$file" > mv "$file.fixed" "$file" > chmod +x "$file" > chmod -w "$file" > done > > The +x was needed for a few of the files (most were OK). Otherwise got > permission denied. > > After the change, most tests pass. There were some failures that remained: > > FAIL: Test-https-pfs.px > FAIL: Test-https-tlsv1.px > FAIL: Test-https-tlsv1x.px > FAIL: Test-https-selfsigned.px > SKIP: Test-https-weboftrust.px > FAIL: Test-https-clientcert.px > FAIL: Test-https-crl.px > PASS: Test-https-badcerts.px > > $ cd ./wget-1.20.3/tests > $ ./Test-https-pfs.px > Can't locate WgetFeature.pm in @INC (you may need to install the > WgetFeature module) (@INC contains: /etc/perl > /usr/local/lib/x86_64-linux-gnu/perl/5.24.1 > /usr/local/share/perl/5.24.1 /usr/lib/x86_64-linux-gnu/perl5/5.24 > /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.24 > /usr/share/perl/5.24 /usr/local/lib/site_perl > /usr/lib/x86_64-linux-gnu/perl-base) at ./Test-https-pfs.px line 6. > BEGIN failed--compilation aborted at ./Test-https-pfs.px line 6.
I don't know Perl, but it looks like this is the problem: https://perlmaven.com/cant-locate-in-inc . And this may be the solution: https://perlmaven.com/how-to-add-a-relative-directory-to-inc . I can't help but laugh at the solutions. It never ceases to amazes me at the f**k'd up convoluted solutions engineers come up with. Apparently 'use ./WgetFeature.pm;' would have been way too easy. And apparently including PWD by default would have been way too easy. We have already accepted the risk of compiling and running Test-https-pfs.px in /some/user/directory. Using WgetFeature.pm, which is side-by-side and needed by Test-https-pfs.px, adds no additional risk. Instead we have to suffer the shit the Perl people came up with. More Darwin awards... Jeff