DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15852>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15852 cache MUST attach Warning 113 to hits older than 24 hours ------- Additional Comments From [EMAIL PROTECTED] 2003-07-21 22:32 ------- I have attached a slightly altered version of attachement 7202. In the existing util_script code, any headers that do not specifically have cases in the switch should get added to the err_headers_out table by default. Headers that need to be passed on, regardless of request processing outcome, are supposed to be added to err_headers_out. Attachement 7202 essentially moved the Expires and Age headers from the err_headers_out over to the headers_out table. This is not correct. The correct action is to look in both places for the header and update it in the location that it was found. You will find that the ap_cache_check_freshness function in cache_util.c now checks for the Age header in both locations. My attached version of the patch (7434) checks both locations for the Expires header. The code should also add the warning to the existing Warning header (wherever it finds it). The 7202 patch also checked if ((age + age_c) > 86400)). This is incorrect because "age" is the corrected age, which is based on "age_c". Adding the two basically doubles the age. It should simply be (age > 86400). The final difference in the two versions of the patch is that RFC 2616 13.2.4 indicates that the 113 warning should be added "if such warning has not already been added." My altered patch checks if 113 is there before adding it. Could you folks at Measurement-Factory please verify that the attached patch (7434) works for you. If so, this will be the version I commit. Thanks for your work Sushma Rai and Co-Advisor. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
