https://issues.apache.org/bugzilla/show_bug.cgi?id=56457
Bug ID: 56457
Summary: mod_proxy_html.c: 2 * cut'n'paste errors
Product: Apache httpd-2
Version: 2.4.9
Hardware: All
OS: Linux
Status: NEW
Severity: normal
Priority: P2
Component: mod_filter
Assignee: [email protected]
Reporter: [email protected]
[mod_proxy_html.c:326]: (style) Expression is always false because 'else if'
condition matches previous condition at line 320.
Source code is
if ((ctx->cfg->doctype == fpi_html) || (ctx->cfg->doctype == fpi_xhtml)) {
/* enforce html */
if (!desc || desc->depr)
return;
}
else if ((ctx->cfg->doctype == fpi_html)
|| (ctx->cfg->doctype == fpi_xhtml)) {
/* enforce html legacy */
if (!desc)
return;
}
[mod_proxy_html.c:379]: (style) Expression is always false because 'else if'
condition matches previous condition at line 372.
if ((ctx->cfg->doctype == fpi_html) || (ctx->cfg->doctype == fpi_xhtml)) {
/* enforce html */
enforce = 2;
if (!desc || desc->depr)
return;
}
else if ((ctx->cfg->doctype == fpi_html)
|| (ctx->cfg->doctype == fpi_xhtml)) {
enforce = 1;
/* enforce html legacy */
if (!desc) {
return;
}
}
I got these two bugs from cppcheck, a static analysis tool.
It found many other things wrong.
I think apache would benefit from meeting cppcheck.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
