https://bz.apache.org/bugzilla/show_bug.cgi?id=62223
--- Comment #2 from Ruediger Pluem <[email protected]> --- (In reply to Yann Ylavic from comment #1) > The goal is to not go above the '\r' here (which is the end of the buffer > but still in the bounds). > > So you raise a good optimization point since the last > apr_isspace(buffer[colon]) check is always true/useless when colon == > *slider (and colon < *slider is probably a cheaper test), but it's not an > out of bounds issue, right? This is how I see it as well. Regarding the optimization: I think in the usual case we do not hit the colon == *slider case. Hence we are slightly better with the current code in the usual case where apr_isspace(buffer[colon]) == 0 causes the while loop to end. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
