https://bz.apache.org/bugzilla/show_bug.cgi?id=69671

tangent <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 OS|                            |All

--- Comment #1 from tangent <[email protected]> ---
A brief update.

Having looked at 2.4.65-rc3, I can see that support/win32/ApacheMonitor.rc has
been updated to reflect the above request. Thankyou.

However, I note the CMakeLists.txt file hasn't been updated to remove the
comment #'s in front of the ApacheMonitor build statements. The following diff
output covers these changes.

C:\Development\apache24\src\httpd-2.4.65>diff -u CMakeLists.txt.orig
CMakeLists.txt
--- CMakeLists.txt.orig Tue Jun 10 11:51:35 2025
+++ CMakeLists.txt      Mon Jul 21 21:37:05 2025
@@ -912,13 +912,13 @@
 ENDIF()
 GET_PROPERTY(tmp_includes TARGET ab PROPERTY INCLUDE_DIRECTORIES)

-# getting duplicate manifest error with ApacheMonitor
-# ADD_EXECUTABLE(ApacheMonitor support/win32/ApacheMonitor.c
support/win32/ApacheMonitor.rc)
-# SET(install_targets ${install_targets} ApacheMonitor)
-# SET(install_bin_pdb ${install_bin_pdb} $<TARGET_PDB_FILE:ApacheMonitor>)
-# SET_TARGET_PROPERTIES(ApacheMonitor PROPERTIES WIN32_EXECUTABLE TRUE)
-# SET_TARGET_PROPERTIES(ApacheMonitor PROPERTIES COMPILE_FLAGS "-DAPP_FILE
-DLONG_NAME=ApacheMonitor -DBIN_NAME=ApacheMonitor.exe ${EXTRA_COMPILE_FLAGS}")
-# TARGET_LINK_LIBRARIES(ApacheMonitor ${EXTRA_LIBS} ${HTTPD_SYSTEM_LIBS}
comctl32 wtsapi32)
+# No longer getting duplicate manifest error with ApacheMonitor
+ADD_EXECUTABLE(ApacheMonitor support/win32/ApacheMonitor.c
support/win32/ApacheMonitor.rc)
+SET(install_targets ${install_targets} ApacheMonitor)
+SET(install_bin_pdb ${install_bin_pdb} $<TARGET_PDB_FILE:ApacheMonitor>)
+SET_TARGET_PROPERTIES(ApacheMonitor PROPERTIES WIN32_EXECUTABLE TRUE)
+SET_TARGET_PROPERTIES(ApacheMonitor PROPERTIES COMPILE_FLAGS "-DAPP_FILE
-DLONG_NAME=ApacheMonitor -DBIN_NAME=ApacheMonitor.exe ${EXTRA_COMPILE_FLAGS}")
+TARGET_LINK_LIBRARIES(ApacheMonitor ${EXTRA_LIBS} ${HTTPD_SYSTEM_LIBS}
comctl32 wtsapi32)

 ###########  CONFIGURATION FILES ###########
 # Set up variables used in the .conf file templates

Could these changes be reviewed and applied to the CMakeLists.txt file please,
so the ApacheMonitor.exe binary gets built using CMake?

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to