https://bz.apache.org/bugzilla/show_bug.cgi?id=69999

--- Comment #3 from abernal <[email protected]> ---
Correction: #919 is closed as a duplicate. It only fixed the ">" vs ">="
comparison, which is correct for ASCII but leaves a separate signed-char bug:
*ip is a plain char, so *ip >> 4 sign-extends for any byte >= 0x80, still
garbling non-ASCII (e.g. UTF-8) usernames.

An earlier, more complete fix for this same bug is already open and green:
https://github.com/apache/httpd/pull/822 -- it casts to unsigned char and uses
a hex digit lookup table, which covers both the ">= 10" boundary and the
signed-char case. That is the PR that should be merged for this bug, not #919.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to