On Fri, Jun 24, 2011 at 01:43:00AM +0100, Jason McIntyre wrote:
> On Fri, Jun 24, 2011 at 02:09:08AM +0200, Cl??ment B??sch wrote:
> > On Sat, Dec 25, 2010 at 07:16:06PM +0100, ClC)ment BEsch wrote:
> > > Hi,
>
> hi. i'm late to the party, so sorry if i've missed some stuff...
>
> > >
> > > There is a few trivial things where the ktrace manpage seems wrong, or
> > > at least incomplete:
> > >
> > > - "The kernel operations that are traced include system calls, namei
> > > translations, signal processing, and I/O.". But according to krace.h,
> > > KTRFAC_EMUL is also traced by default.
> > >
>
> "include" means here is a subset. it doesn;t mean here is everything. so
> that is not neccessarily wrong.
>
Sure, but it sounds incomplete.
> > > - The '+' joker supported in getpoints is not documented in manpage.
> > >
> > > - The -c switch does not need a file or pid to be precised since it
> > > fallbacks on the default filename ("ktrace.out").
> > >
>
> where does ktrace(1) document that -c requires an argument?
>
The sentence makes the user think -f, -g or -p must be specified IMO.
> >
> > Should I send a patch?
> >
>
> in general, yes.
>
OK, attached.
--
ClC)ment B.
--- ktrace.1 2007-05-31 21:20:11.000000000 +0200
+++ ktrace.1 2011-06-24 09:09:30.972437526 +0200
@@ -56,7 +56,7 @@
.Fl f
option.
The kernel operations that are traced include system calls, namei
-translations, signal processing, and I/O.
+translations, signal processing, I/O and emulation changes.
.Pp
Once tracing is enabled on a process, trace data will be logged until
either the process exits or the trace point is cleared.
@@ -80,7 +80,16 @@
Disable tracing on all user owned processes, and, if executed by root, all
processes in the system.
.It Fl c
-Clear the trace points associated with the specified file or processes.
+Clear the trace points associated with the specified file and processes (or
+with the default
+.Pa ktrace.out
+file if no
+.Fl f
+,
+.Fl g
+nor
+.Fl p
+are specified).
.It Fl d
Descendants; perform the operation for all current children of the
designated processes.
@@ -124,6 +133,8 @@
trace signal processing
.It Cm w
trace context switch points
+.It Cm +
+trace the default points
.El
.It Ar command
Execute
