On Fri, Jun 24, 2011 at 09:12:07AM +0200, Cl??ment B??sch wrote:
> >
> > "include" means here is a subset. it doesn;t mean here is everything. so
> > that is not neccessarily wrong.
> >
>
> Sure, but it sounds incomplete.
>
because you are expecting a full list. but none is promised.
> > > > - The '+' joker supported in getpoints is not documented in manpage.
> > > >
> > > > - The -c switch does not need a file or pid to be precised since it
> > > > fallbacks on the default filename ("ktrace.out").
> > > >
> >
> > where does ktrace(1) document that -c requires an argument?
> >
>
> The sentence makes the user think -f, -g or -p must be specified IMO.
>
yes, sorry, i failed to see that. it does sound like a file needs to be
specified.
> > >
> > > Should I send a patch?
> > >
> >
> > in general, yes.
> >
>
> OK, attached.
>
> --
> ClC)ment B.
> --- ktrace.1 2007-05-31 21:20:11.000000000 +0200
> +++ ktrace.1 2011-06-24 09:09:30.972437526 +0200
> @@ -56,7 +56,7 @@
> .Fl f
> option.
> The kernel operations that are traced include system calls, namei
> -translations, signal processing, and I/O.
> +translations, signal processing, I/O and emulation changes.
ok, i'm not against this (if it's correct - i don;t myself know). but if
we do make the change, we should change "include" to "are". and then we
will have to keep on top of any other things that are traced, and verify
that the current list is complete - can you do that, please?
> .Pp
> Once tracing is enabled on a process, trace data will be logged until
> either the process exits or the trace point is cleared.
> @@ -80,7 +80,16 @@
> Disable tracing on all user owned processes, and, if executed by root, all
> processes in the system.
> .It Fl c
> -Clear the trace points associated with the specified file or processes.
> +Clear the trace points associated with the specified file and processes (or
> +with the default
> +.Pa ktrace.out
> +file if no
> +.Fl f
> +,
> +.Fl g
> +nor
> +.Fl p
> +are specified).
this is not a good way to do it. it's very verbose, for no gain. the
description of the -a option handles it much better, i think. so i'd go
for something like:
-c Clear the trace points associated with the trace file
or any specified processes.
however the word "or" may be incorrect. i don;t know enough about how
ktrace works. should it be "and", or is "or" possible?
> .It Fl d
> Descendants; perform the operation for all current children of the
> designated processes.
> @@ -124,6 +133,8 @@
> trace signal processing
> .It Cm w
> trace context switch points
> +.It Cm +
> +trace the default points
that seems correct, but i'd like a developer to verify it's sane.
> .El
> .It Ar command
> Execute
>
jmc
