Hey Kenneth, On Mon, Aug 05, 2013 at 11:56:53PM -0400, Kenneth R Westerback wrote: > > Prior the last change, bind_lease() unconditionally called flush_routes(). > > However, flush_routes() in [1] is documented to be equivalent to `route -q > > $rdomain -n flush -inet -iface $interface` (note the -inet), which might > > contradict my understanding of the cause. > > > > [0] http://www.openbsd.org/cgi-bin/cvsweb/src/sbin/dhclient/dhclient.c?rev=1.260 > > [1] http://www.openbsd.org/cgi-bin/cvsweb/src/sbin/dhclient/kroute.c?rev=1.55 > Pretty sure I fixed this by 5.4. If you can reproduce in 5.4 I would > be extremely interested.
As mentioned on ipv6@, I got slightly confused staring at various versions of a file at once, namely, kroute.c. 5.3 had 1.40 [2], which doesn't have a [priv_]flush_routes(), but only [priv_]flush_routes_and_arp_cache(). The priv_ variant says nothing about AF_INET (mib[3] = 0). This is not the case in 1.55, as it appears to have been fixed with 1.47 [3]. The problem was on a 5.3 release machine. I'll try to get a current going in a similar situation, and see if I can reproduce the problem, but now that I have read the code with the right references, I agree with you that it should be fixed in 5.4 already (as of 1.47 [3]). [2] http://www.openbsd.org/cgi-bin/cvsweb/src/sbin/dhclient/kroute.c?rev=1.40;onl y_with_tag=OPENBSD_5_3_BASE [3] http://www.openbsd.org/cgi-bin/cvsweb/src/sbin/dhclient/kroute.c#rev1.47 -- Olivier Mehani <[email protected]> PGP fingerprint: 4435 CF6A 7C8D DD9B E2DE F5F9 F012 A6E2 98C6 6655 [demime 1.01d removed an attachment of type application/pgp-signature]
