On Wed, Apr 18, 2018 at 02:15:50PM +0200, Alexander Bluhm wrote:
> On Wed, Apr 18, 2018 at 08:30:16PM +1000, Jonathan Gray wrote:
> > On Wed, Apr 18, 2018 at 11:40:06AM +0200, Alexander Bluhm wrote:
> > > my i386 regression test machine crashed with the Tue Apr 17 snapshot
> > > in radeondrm_attachhook().
> >
> > So the machine doesn't have /etc/firmware/radeon/R100_cp.bin ?
>
> No firmware installed. And I don't use vga, console is serial.
>
> bluhm
>
sys/dev/pci/drm/drm_linux.h rev 1.85 should help
Though there is another problem I noticed. When the firmware is not present
radeondrm is detached. With the diff in snapshots a bus_space_unmap() call
is made with the wrong bus space tag in that path.
diff --git sys/dev/pci/drm/radeon/radeon_device.c
sys/dev/pci/drm/radeon/radeon_device.c
index 9085bf845c4..ec631f66cd9 100644
--- sys/dev/pci/drm/radeon/radeon_device.c
+++ sys/dev/pci/drm/radeon/radeon_device.c
@@ -1582,7 +1582,7 @@ void radeon_device_fini(struct radeon_device *rdev)
rdev->rmmio = NULL;
#else
if (rdev->rio_mem_size > 0)
- bus_space_unmap(rdev->memt, rdev->rio_mem, rdev->rio_mem_size);
+ bus_space_unmap(rdev->iot, rdev->rio_mem, rdev->rio_mem_size);
rdev->rio_mem_size = 0;
if (rdev->rmmio_size > 0)
