On Sun, Oct 28, 2018 at 06:45:16PM +0100, Klemens Nanni wrote:
> On Sun, Oct 28, 2018 at 06:19:11PM +0100, Matthieu Herrb wrote:
> > -    strlcpy(prompt, message, messageLen);
> > +    strlcpy(prompt, message, messageLen+3);
> So this turns "logi" into "login: "?

Yes.
> 
> Not a big deal, but these `messageLen +- MAGIC_OFFSET' seem somewhat
> hackish.
> 
> Can you add spaces so it's consistent with the rest at least?

Sure this is terrible. It's still from xdm. I wanted to clean that up
in LJU last july but didn't find the time.

The whole way the login widget layout is computed is hackish and not
very robust. It needs to be redone at some point.

-- 
Matthieu Herrb

Reply via email to