Hi Ted,

i only saw your reply after sending mine.

Ted Unangst wrote on Sun, Jan 06, 2019 at 02:10:40PM -0500:

> This is meant to be programmer documentation, so I think it makes sense to
> keep it referring to sysctl.2. However, it's a good point that you shouldn't
> have to grep for clockinfo.
> 
> If we mention KERN_CLOCKRATE that makes searching faster and should allow
> users to figure out kern.clockrate.

Arguably, since

  $ man -O tag=struct_clockinfo 2 sysctl

works whereas

  $ man -O tag=clockinfo 2 sysctl

does not.  (However, now that i think about it, i think that
tag=clockinfo probably ought to work as well, and i have some ideas
how to make it work.)

Anyway, i'm not opposed to your version of the patch.  But if you decide
to commit it, please make it

  .Dv KERN_CLOCKRATE

because that's a #define'ed constant, not a placeholder where the user
has to substitute something else.

Yours,
  Ingo


> Index: hz.9
> ===================================================================
> RCS file: /cvs/src/share/man/man9/hz.9,v
> retrieving revision 1.8
> diff -u -p -r1.8 hz.9
> --- hz.9      12 Jan 2018 04:36:45 -0000      1.8
> +++ hz.9      6 Jan 2019 19:07:27 -0000
> @@ -79,7 +79,9 @@ may be used to skew this increment, but 
>  than ten times
>  .Va tickadj .
>  .Pp
> -Those systems variables are available as a struct clockinfo from
> +These system variables are available by reading
> +.Va KERN_CLOCKRATE
> +from
>  .Xr sysctl 2 .
>  .Sh SEE ALSO
>  .Xr adjtime 2 ,
> 

Reply via email to