On Sun, 6 Jan 2019 20:40:17 +0100 Ingo Schwarze <[email protected]> wrote:
> Hi Ted, > > i only saw your reply after sending mine. > > Ted Unangst wrote on Sun, Jan 06, 2019 at 02:10:40PM -0500: > > > This is meant to be programmer documentation, so I think it makes sense to > > keep it referring to sysctl.2. However, it's a good point that you shouldn't > > have to grep for clockinfo. > > > > If we mention KERN_CLOCKRATE that makes searching faster and should allow > > users to figure out kern.clockrate. > > Arguably, since > > $ man -O tag=struct_clockinfo 2 sysctl > > works whereas > > $ man -O tag=clockinfo 2 sysctl > > does not. (However, now that i think about it, i think that > tag=clockinfo probably ought to work as well, and i have some ideas > how to make it work.) > > Anyway, i'm not opposed to your version of the patch. But if you decide > to commit it, please make it > > .Dv KERN_CLOCKRATE > > because that's a #define'ed constant, not a placeholder where the user > has to substitute something else. > Thanks for the clue stick and feedback!
