On Wed, Feb 13, 2019 at 10:37:48AM -0200, Martin Pieuchot wrote: > On 11/02/19(Mon) 18:58, Artturi Alm wrote: > > On Mon, Feb 11, 2019 at 02:15:43PM -0200, Martin Pieuchot wrote: > > > On 10/02/19(Sun) 20:46, Artturi Alm wrote: > > > > Hi, > > > > > > > > rather than patching uhub(4), i figured this would be less not-ok, > > > > if not ok as-is, given its way more limited scope. > > > > > > Why shouldn't we patch uhub(4)? > > > > > > > There's no MD code in uhub(4), and i don't know what to fix there yet, > > but the workaround i was referring to w/"patching" has MI side-effects. > > > > > > diff below works for me, but i suppose playing w/timeouts is a must, > > > > for root on nfs? > > > > > > What is the issue? Could you explain it in words? That would allow > > > us to find a solution together :o) > > > > > > > I thought this was known, i'm sorry; i should have linked to the details[0]. > > Sorry but that mail describes symptoms. What is the problem? Why your > diff work? What did you do to write this workaround? What could be > another alternative to the fix your proposing?
I haven't really diagnosed this at all, except dmesgs over irc|reading uhub.c, when i didn't have the hw yet. And the reason to that is here[0]; somewhat ignored bug report, which made me swear i'd never look anything at /sys/dev/usb/dwc2/ again until i see progress made by others in there. I ran into some INVAL spam with the "port reset in uhub_explore()" hack, so i needed something better, and aimed at minimal +++only diff, obviously with some guesswork. I don't honestly care about rpi3 as much as other users it has do, and i don't want to waste your time anymore with this(nor the bug in link[0]), so i'll let this be for now, as both of the trees i'm compiling/testing stuff on rpi3 over nfs(w/mue(4)) have incomplete work within, and i'm lazy even with git at times:] Hopefully someone else will come up with something better:] -Artturi ps. the rthread rwlock improvement is great, thank you :) [0] https://marc.info/?t=150188616000004&r=1&w=2
