On Sun, Jun 21, 2026 at 11:08:27PM +0200, Marc Espie wrote:
> On Sun, Jun 21, 2026 at 10:52:21PM +0200, Matthias Kilian wrote:
> > Hi,
> > 
> > On Sun, Jun 21, 2026 at 11:35:39AM -0700, Andrew Hewus Fresh wrote:
> > > As far as I know, the default PKG_PATH has included the current
> > > directory nearly from the start.
> > > 
> > > https://github.com/openbsd/src/commit/86fd39bc815c07599fed3993f842dc5b4117c412
> > > 
> > > With the addition of using the "installpath" (which comes from
> > > /etc/installurl) that probably doesn't make a whole lot of sense
> > > anymore, especially as folks usually don't keep packages in the
> > > directory where they run any of the pkg tooling.  Plus, all it does is
> > > surprisingly complain about not being a trusted package if you do have
> > > one.
> > > 
> > > https://github.com/openbsd/src/commit/b1b61206d60851b7b85c170a97c4c2afb7eed612
> > > 
> > > Comments, OK?
> > 
> > I think, removing . as deault search path is sane, but this would
> > also at least require little changes to the man page like below
> > (feel free to just include this if you get real oks).

Many thanks for this patch, I used it.


> > Ciao,
> >     Kili
> > 
> > Index: pkg_add.1
> > ===================================================================
> > RCS file: /cvs/src/usr.sbin/pkg_add/pkg_add.1,v
> > diff -u -p -r1.170 pkg_add.1
> > --- pkg_add.1       22 May 2025 01:40:21 -0000      1.170
> > +++ pkg_add.1       21 Jun 2026 20:49:10 -0000
> > @@ -142,9 +142,9 @@ Each package name may be specified as a 
> >  package name itself plus the
> >  .Dq .tgz
> >  suffix) or a URL referring to FTP, HTTP, HTTPS, or SCP locations.
> > -If the given package names are not found in the current working directory,
> >  .Nm
> > -will search for them in each directory (local or remote) named by the
> > +will search for the given package names in each directory (local or
> > +remote) named by the
> >  .Ev TRUSTED_PKG_PATH
> >  environment variable,
> >  then the
> > @@ -161,7 +161,7 @@ nor
> >  are defined,
> >  .Nm
> >  will use
> > -.Sq ./:installpath
> > +.Sq installpath
> >  as a default.
> >  .Pp
> >  .Nm
> > 
> Apart from the manpage, did you guys actually run with this for a while
> and checked that it doesn't break anything ?

I tested it a bit, adding packages and installing and updating ports.


> There's a bunch of tricky defaults in there that are not necessarily
> useful, but actually *require* people to play with it for a while
> until you're sure it doesn't break anything.

Easy enough to back out if something surprising comes up.


> Happened to me a bunch of times. Got into one too many fights with Theo
> about something pretty similar that couldn't break, but did.
> 
> Your funeral.

That's as good as an OK :-D


l8rZ,
-- 
andrew

If your computer says, "Printer out of Paper," this problem cannot
      be resolved by continuously clicking the "OK" button.

Reply via email to