Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/900 was reviewed by Joel Sherrill
-- Joel Sherrill started a new discussion on bsps/powerpc/motorola_powerpc/bootloader/zlib.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/900#note_138956 > Bytef *buf, This is third party code and shouldn't be modified. Any absolutely necessary changes should be like this: ``` #ifdef __rtems__ rtems way #else original unmodified code #endif ``` For this case, unless this is fixing a warning, revert this change. -- Joel Sherrill started a new discussion on bsps/powerpc/motorola_powerpc/start/residual.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/900#note_138957 > -/* SPDX-License-Identifier: GPL-2.0+-with-RTEMS-exception */ > +#include <stdint.h> > +/* SPDX-License-Identifier: BSD-2-Clause */ SPDX should be first line. Move #include below the copyright/license block. -- Joel Sherrill started a new discussion on bsps/powerpc/motorola_powerpc/start/bspreset.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/900#note_138958 > +#include <stdint.h> Move #include below copyright/license -- View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/900 You're receiving this email because of your account on gitlab.rtems.org.
_______________________________________________ bugs mailing list [email protected] http://lists.rtems.org/mailman/listinfo/bugs
