Gedare Bloom started a new discussion on bsps/i386/include/bsp/apic.h: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1121#note_145147

 > + */
 > +static inline uint8_t lapic_get_id(void)
 > +{
 > +    /* ID stored in highest 8 bits */
 > +    return i386_lapic_base[LAPIC_REGISTER_ID]>>24;
 > +}
 > +
 > +/**
 > + * @brief Sends an End of Interrupt (EOI) signal to the Local APIC.
 > + */
 > +static inline void lapic_send_eoi(void)
 > +{
 > +    (void) i386_lapic_base[LAPIC_REGISTER_SPURIOUS];
 > +    i386_lapic_base[LAPIC_REGISTER_EOI] = LAPIC_EOI_ACK; 
 > +}
 > +

Instead of copy-paste-modify, we should aim to share the code between the i386 
and x86_64 ports.

-- 
View it on GitLab: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1121#note_145147
You're receiving this email because of your account on gitlab.rtems.org.


_______________________________________________
bugs mailing list
[email protected]
http://lists.rtems.org/mailman/listinfo/bugs

Reply via email to