Mohammed Anees commented on a discussion on bsps/i386/include/bsp/apic.h: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1121#note_145160 > + */ > +static inline uint8_t lapic_get_id(void) > +{ > + /* ID stored in highest 8 bits */ > + return i386_lapic_base[LAPIC_REGISTER_ID]>>24; > +} > + > +/** > + * @brief Sends an End of Interrupt (EOI) signal to the Local APIC. > + */ > +static inline void lapic_send_eoi(void) > +{ > + (void) i386_lapic_base[LAPIC_REGISTER_SPURIOUS]; > + i386_lapic_base[LAPIC_REGISTER_EOI] = LAPIC_EOI_ACK; > +} > + i completely agree on this with you, my intention for this MR was to keep the scope limited to decoupling the LAPIC functionality alone as fully consolidating the LAPIC headers would likely require touching both ports simultaneously and wasn't sure if that is the right call. Also there are different naming conventions used and some variable pretty as the arch as prefix like `amd64_lapic_base` Ill definitely address this in a separate MR if that is fine, or in the same, whatever you think is best. -- View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1121#note_145160 You're receiving this email because of your account on gitlab.rtems.org.
_______________________________________________ bugs mailing list [email protected] http://lists.rtems.org/mailman/listinfo/bugs
