Mohamed Ayman commented on a discussion on 
bsps/arm/stm32f4/include/bsp/stm32_usart.h: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1130#note_146211

 >  #define STM32F4_USART_DR_GET(reg) BSP_FLD32GET(reg, 0, 7)
 >  #define STM32F4_USART_DR_SET(reg, val) BSP_FLD32SET(reg, val, 0, 7)
 > -    uint32_t bbr;
 > -#define STM32F4_USART_BBR_DIV_MANTISSA(val) BSP_FLD32(val, 4, 15)
 > -#define STM32F4_USART_BBR_DIV_MANTISSA_GET(reg) BSP_FLD32GET(reg, 4, 15)
 > -#define STM32F4_USART_BBR_DIV_MANTISSA_SET(reg, val) BSP_FLD32SET(reg, val, 
 > 4, 15)
 > -#define STM32F4_USART_BBR_DIV_FRACTION(val) BSP_FLD32(val, 0, 3)
 > -#define STM32F4_USART_BBR_DIV_FRACTION_GET(reg) BSP_FLD32GET(reg, 0, 3)
 > -#define STM32F4_USART_BBR_DIV_FRACTION_SET(reg, val) BSP_FLD32SET(reg, val, 
 > 0, 3)
 > +    uint32_t brr;
 > +#define STM32F4_USART_BRR_DIV_MANTISSA(val) BSP_FLD32(val, 4, 15)
 > +#define STM32F4_USART_BRR_DIV_MANTISSA_GET(reg) BSP_FLD32GET(reg, 4, 15)
 > +#define STM32F4_USART_BRR_DIV_MANTISSA_SET(reg, val) BSP_FLD32SET(reg, val, 
 > 4, 15)
 > +#define STM32F4_USART_BRR_DIV_FRACTION(val) BSP_FLD32(val, 0, 3)
 > +#define STM32F4_USART_BRR_DIV_FRACTION_GET(reg) BSP_FLD32GET(reg, 0, 3)
 > +#define STM32F4_USART_BRR_DIV_FRACTION_SET(reg, val) BSP_FLD32SET(reg, val, 
 > 0, 3)

![Screenshot from 2026-03-19 
16-49-54.png](/uploads/26a054ac71d30c5b959ce0c45c6a2357/Screenshot_from_2026-03-19_16-49-54.png){width=900
 height=446}

![Screenshot from 2026-03-19 
16-52-32.png](/uploads/fdfaf3e52e8e55d595575aa3dc121bbc/Screenshot_from_2026-03-19_16-52-32.png){width=900
 height=127}

In the first part of the first image, which shows the main source repository, 
only **BBR** appears in the files I edited. In the second part of the first 
image, since I ran the command on the entire source code, **BRR** appears and 
is used in other drivers. This demonstrates that **BRR** is the standard naming 
convention. It is also used in **STM32H7**, which serves as a design reference 
for **STM32F4**.

In the second image, I show the changes I made to update the naming in the main 
source (first part of the first image) from **BBR** to **BRR**.

-- 
View it on GitLab: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1130#note_146211
You're receiving this email because of your account on gitlab.rtems.org.


_______________________________________________
bugs mailing list
[email protected]
http://lists.rtems.org/mailman/listinfo/bugs

Reply via email to