Mohamed Ayman commented on a discussion on 
bsps/arm/stm32f4/include/bsp/stm32_usart.h: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1130#note_146220

 >  #define STM32F4_USART_DR_GET(reg) BSP_FLD32GET(reg, 0, 7)
 >  #define STM32F4_USART_DR_SET(reg, val) BSP_FLD32SET(reg, val, 0, 7)
 > -    uint32_t bbr;
 > -#define STM32F4_USART_BBR_DIV_MANTISSA(val) BSP_FLD32(val, 4, 15)
 > -#define STM32F4_USART_BBR_DIV_MANTISSA_GET(reg) BSP_FLD32GET(reg, 4, 15)
 > -#define STM32F4_USART_BBR_DIV_MANTISSA_SET(reg, val) BSP_FLD32SET(reg, val, 
 > 4, 15)
 > -#define STM32F4_USART_BBR_DIV_FRACTION(val) BSP_FLD32(val, 0, 3)
 > -#define STM32F4_USART_BBR_DIV_FRACTION_GET(reg) BSP_FLD32GET(reg, 0, 3)
 > -#define STM32F4_USART_BBR_DIV_FRACTION_SET(reg, val) BSP_FLD32SET(reg, val, 
 > 0, 3)
 > +    uint32_t brr;
 > +#define STM32F4_USART_BRR_DIV_MANTISSA(val) BSP_FLD32(val, 4, 15)
 > +#define STM32F4_USART_BRR_DIV_MANTISSA_GET(reg) BSP_FLD32GET(reg, 4, 15)
 > +#define STM32F4_USART_BRR_DIV_MANTISSA_SET(reg, val) BSP_FLD32SET(reg, val, 
 > 4, 15)
 > +#define STM32F4_USART_BRR_DIV_FRACTION(val) BSP_FLD32(val, 0, 3)
 > +#define STM32F4_USART_BRR_DIV_FRACTION_GET(reg) BSP_FLD32GET(reg, 0, 3)
 > +#define STM32F4_USART_BRR_DIV_FRACTION_SET(reg, val) BSP_FLD32SET(reg, val, 
 > 0, 3)

hi Wayne,

This update is to ensure correctness and consistency across the codebase(cause 
stm32f4 driver is still under development).

The register is officially named **BRR (Baud Rate Register)**, so the previous 
BBR naming was incorrect. I updated it to match the hardware specification and 
to stay consistent with other drivers like STM32H7 .

I also updated all affected usages (such as in usart.c) and verified that there 
are no remaining dependencies on the old BBR naming.

-- 
View it on GitLab: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1130#note_146220
You're receiving this email because of your account on gitlab.rtems.org.


_______________________________________________
bugs mailing list
[email protected]
http://lists.rtems.org/mailman/listinfo/bugs

Reply via email to