Gedare Bloom commented on a discussion on cpukit/include/rtems/dhrl.h: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1193#note_150587

 > +/* SPDX-License-Identifier: BSD-2-Clause */
 > +
 > +/**
 > + * @file
 > + *
 > + * @brief Deterministic Hedged Read Library (DHRL) Public API
 > + *
 > + * @note This library is explicitly constrained to x86_64/amd64 
 > architectures.

I'll take another pass through it.

If the hardware must support those features, I would make those features 
explicitly required, and break/prevent any attempt to build the library if 
those features are missing. This can be done through a combination of the 
`spec/build` and the CPU port macro definitions:
* if the `_CPU_Pause_speculation` is not defined, should an attempt to compile 
fail?
* You can make the `spec/build/cpukit/libdhrl.yml` depend on RTEMS_SMP.

-- 
View it on GitLab: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1193#note_150587
You're receiving this email because of your account on gitlab.rtems.org.


_______________________________________________
bugs mailing list
[email protected]
http://lists.rtems.org/mailman/listinfo/bugs

Reply via email to