Wayne Thornton commented on a discussion on cpukit/include/rtems/dhrl.h: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1193#note_150605

 > +/* SPDX-License-Identifier: BSD-2-Clause */
 > +
 > +/**
 > + * @file
 > + *
 > + * @brief Deterministic Hedged Read Library (DHRL) Public API
 > + *
 > + * @note This library is explicitly constrained to x86_64/amd64 
 > architectures.

@gedare That makes perfect sense. I agree that failing loudly at compile-time 
is much safer than allowing silent fallbacks on unsupported hardware.

I removed the empty assembly fallback in dhrl.c and replaced it with an #error 
directive. If _CPU_Pause_speculation is missing, the build will now explicitly 
halt.

The spec/build/cpukit/libdhrl.yml specification to include enabled-by: 
RTEMS_SMP was already included and the build system was already entirely 
skipping the library on uni-processor targets.

-- 
View it on GitLab: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1193#note_150605
You're receiving this email because of your account on gitlab.rtems.org.


_______________________________________________
bugs mailing list
[email protected]
http://lists.rtems.org/mailman/listinfo/bugs

Reply via email to