Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1391 
was reviewed by Joel Sherrill

--
  
Joel Sherrill started a new discussion on bsps/riscv/include/bsp/riscv-rnmi.h: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1391#note_158058

 > +/*
 > + * Copyright (C) 2026 Intel Corporation
 > + */

RTEMS style is to include a Doxygen @file block after the SPDX line and to 
include the text of the license below the copyright. Move the @file block above 
the license block and include the license text.

his impacts multiple files.

--
  
Joel Sherrill started a new discussion on testsuites/samples/ticker/tasks.c: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1391#note_158059

 >  #include "system.h"
 >  
 > +// TEST METHODOLOGY

This file has changes which should not be pushed.

I think most of the information here can go in the Users Guide in the 
appropriate BSP section.

This isn't adding a new BSP as far as I can tell. Should there be one added to 
test this feature? I think that would be prudent so the option can be regularly 
tested.

And if a BSP variant is added, the qemu command should be turned into a BSP 
configuration for the rtems-tester.


-- 
View it on GitLab: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1391
You're receiving this email because of your account on gitlab.rtems.org. 
Unsubscribe from this thread: 
https://gitlab.rtems.org/-/sent_notifications/5-7kyi6sfzwbb70mbqkmso4hnc4-1d/unsubscribe
 | Manage all notifications: https://gitlab.rtems.org/-/profile/notifications | 
Help: https://gitlab.rtems.org/help


_______________________________________________
bugs mailing list
[email protected]
http://lists.rtems.org/mailman/listinfo/bugs

Reply via email to