2009/4/9 Alan Bateman <alan.bate...@sun.com>: > Andrew Haley wrote: >> >> : >> The page is at http://icedtea.classpath.org/wiki/IcedTea_JDK6_Patches >> These are the patches in icedtea/patches and icedtea/patches/hotspot. >> >> >> * Every patch should be assigned to someone. >> >> * Every patch should be discussed. >> >> * If we can, we will push a patch upstream. If we can't the discussion >> should explain why we can't. >> >> Here we go... >> >> Andrew. >> > > I'm not very familiar with IcedTea but I cloned the repository to see what > these patches are about. Here are a few comments: > > icedtea-6728542-epoll.patch seems to be a change-set I pushed to jdk7 last > year. It seems very reasonable to push this into jdk6/jdk6/jdk. Go for it! > > icedtea-bytebuffer-compact.patch - this looks to be a partial fix to > 6593946. If so, 6593946 is already in jdk6/jdk6/jdk > (http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/3e7bfcdcf96f). > > icedtea-io_util-overflow.patch - this looks like the initial fix for > 6788196. Martin has already pushed this to jdk6/jdk7/jdk > (http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/cc4d93e8ae7d). > > icedtea-jvmtiEnv.patch - I thought JvmtiEnv::GetLineNumberTable already > handled this case so I'm curious why this one is needed. > > icedtea-network-unreachable.patch - I'm pretty sure net-dev would be open to > this because it looks to be cases where the specific exceptions aren't > thrown in the timed read case. > > icedtea-sunsrc.patch - I'm not sure what this is about but it looks like it > removes the service configuration files. Does JDI still work? > > icedtea-testenv.patch - the changes to > test/sun/net/InetAddress/nameservice/dns/cname.sh seems reasonable (pilot > error is why this one was missed when the other tests were updated). > > icedtea-jtreg-hatrun.patch - I suspect this is 6545295. We should just fix > this test (serviceability-dev). > > -Alan. > > PS: I'm not on distro-pkg-dev so this mail might need the moderator to > approve. > >
Woah, thanks for the quick response on this :) I'll have a quick look at these after the conf. call but good to know a few are possibles for going in. I've just been trying to write off a few low-hanging fruits that I know are in OpenJDK7, or don't need to be pushed. Thanks again, -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8
