On 11/6/2012 2:14 PM, Kelly O'Hair wrote:
Seems to me that the default for build-infra's SetupJavaCompilation macro 
should be -source 8 -target 8, and only
changed by special cases.
Right now, it looks like jaxp, jaxws, and corba need to change their FLAGS 
settings.
so you are saying jax* and corba are using -source/target 8 ?

Kumar


-kto

On Nov 2, 2012, at 6:51 AM, Kumar Srinivasan wrote:

Hello Erik,

For the new build, the change is done in jdk/makefiles/Setup.gmk, in the macro 
call for GENERATE_JDKBYTECODE. Would be nice if that change went in the same 
changeset.
Thanks for the tip.

This change is only for the jdk repo. Don't we need to change the other repos 
(jaxp, jaxws and corba) as well?
Yes this change is for jdk only, the other repos will need to be updated as
needed in the future (they may have their restrictions or preferences), but
we need to get this done for the jdk asap, as Lambda and other JSR
changes will commence their integrations.

Thanks
Kumar

/Erik

On 2012-11-01 02:38, David Holmes wrote:
Hi Kumar,

So after this jdk8 builds will have to use current langtools javac in order to 
work?

The corresponding changes to the new build system will be needed as well.

David

On 1/11/2012 3:43 AM, Kumar Srinivasan wrote:
Hello,

Please review changes to rev up the default -source and -target for jdk
compilation,
thus producing v52.0 class files.

Bug is here:
https://jbs.oracle.com/bugs/browse/JDK-8001191

Webrev is here:
http://cr.openjdk.java.net/~ksrini/8001191/webrev.0/

Note: this webrev is generated against the master repository but changes
will be
pushed via tl after the tl-master sync is completed.

Thanks
Kumar


Reply via email to