Currently jaxp, jaxws and corba use explicit -source 7 -target 7 using
the bootstrap javac in the old build. In build infra it seems this
didn't get converted and these three repos are being compiled with the
defaults from the bootstrap javac. The comparisons match up since since
the defaults are still 7. This should be fixed.
Speaking of javac parameters, jaxp and jaxws are both compiled with -g
flag while the rest of the jdk is not.
/Erik
On 2012-11-07 00:17, Kelly O'Hair wrote:
On Nov 6, 2012, at 2:45 PM, Kumar Srinivasan wrote:
On 11/6/2012 2:14 PM, Kelly O'Hair wrote:
Seems to me that the default for build-infra's SetupJavaCompilation macro
should be -source 8 -target 8, and only
changed by special cases.
Right now, it looks like jaxp, jaxws, and corba need to change their FLAGS
settings.
so you are saying jax* and corba are using -source/target 8 ?
I suspect they are not. They would probably get whatever the default is for the
boot javac.jar, but I'm guessing a bit here.
-kto
Kumar
-kto
On Nov 2, 2012, at 6:51 AM, Kumar Srinivasan wrote:
Hello Erik,
For the new build, the change is done in jdk/makefiles/Setup.gmk, in the macro
call for GENERATE_JDKBYTECODE. Would be nice if that change went in the same
changeset.
Thanks for the tip.
This change is only for the jdk repo. Don't we need to change the other repos
(jaxp, jaxws and corba) as well?
Yes this change is for jdk only, the other repos will need to be updated as
needed in the future (they may have their restrictions or preferences), but
we need to get this done for the jdk asap, as Lambda and other JSR
changes will commence their integrations.
Thanks
Kumar
/Erik
On 2012-11-01 02:38, David Holmes wrote:
Hi Kumar,
So after this jdk8 builds will have to use current langtools javac in order to
work?
The corresponding changes to the new build system will be needed as well.
David
On 1/11/2012 3:43 AM, Kumar Srinivasan wrote:
Hello,
Please review changes to rev up the default -source and -target for jdk
compilation,
thus producing v52.0 class files.
Bug is here:
https://jbs.oracle.com/bugs/browse/JDK-8001191
Webrev is here:
http://cr.openjdk.java.net/~ksrini/8001191/webrev.0/
Note: this webrev is generated against the master repository but changes
will be
pushed via tl after the tl-master sync is completed.
Thanks
Kumar
