On 2012-11-08 11:52, David Holmes wrote:
On 8/11/2012 7:59 PM, Fredrik Öhrström wrote:
It seems that some changes (like introduction of cmshalf.c) did not
update the new makefiles
and caused the OpenJDK only build to fail.
http://cr.openjdk.java.net/~ohrstrom/webrev-8003161-root/
I don't understand this:
$$(shell $(MKDIR) -p $$($1_BIN) && $(RM)
$$($1_BIN)/_the.$$($1_JARNAME)_include)
If you have to create the directory there can't possibly be anything
to rm. ???
If it's a rebuild, the file already exists and needs to be removed
before ListPathsSafely can append to it. That's the old logic. Fredrik
discovered a case where the directory being written to didn't exist yet
and so added the mkdir -p to make sure it exists before calling
ListPathsSafely.
http://cr.openjdk.java.net/~ohrstrom/webrev-8003161-jdk/
Ok. These lists of source files are so error prone.
They are indeed.
/Erik
