On Tue, Mar 5, 2013 at 1:53 PM, David Holmes <david.hol...@oracle.com>wrote:
> > You needed to have a jdk8 Reviewer listed for this change. Erik is a > Committer not Reviewer. > > That's not obvious. Isn't it jcheck's job to make sure any required approvals are in? I should have included more eyeball names on the Reviewed-by: line anyways. > (only tested on Linux) >> > > I sincerely hope Erik tested on Windows, BSD and Solaris before this was > pushed! > This kind of change is very hard for folks outside of Oracle to test, without jprt access. On the other hand, any breakage is easy to detect and fix. Let's not be too afraid to make changes!
