On 6/03/2013 8:24 AM, Martin Buchholz wrote:
On Tue, Mar 5, 2013 at 1:53 PM, David Holmes <david.hol...@oracle.com
<mailto:david.hol...@oracle.com>> wrote:
You needed to have a jdk8 Reviewer listed for this change. Erik is a
Committer not Reviewer.
That's not obvious. Isn't it jcheck's job to make sure any required
approvals are in?
It should be but obviously it does not do that check. That said you are
an OpenJDK Reviewer and you should be familiar with the OpenJDK rules.
I should have included more eyeball names on the Reviewed-by: line anyways.
Yes - mine would have fulfilled the requirement. ;-)
(only tested on Linux)
I sincerely hope Erik tested on Windows, BSD and Solaris before this
was pushed!
This kind of change is very hard for folks outside of Oracle to test,
without jprt access. On the other hand, any breakage is easy to detect
and fix. Let's not be too afraid to make changes!
Sorry but that is completely unacceptable. If you are providing changes
that obviously impact multiple platforms (ie there are platform specific
changes) then they _must_ be tested on all platforms. If the external
author/committer can not do that then they must work with someone in
Oracle who can assist with JPRT runs etc.
David
