Hi Ioi,
I've tried your patch on vs2010 and it seems working fine.
I was able to generate a project file and used vs2010 to open the
project file.
So I think your fix is good. (I'm not a Reviewer)
Calvin
On 8/9/2013 5:39 PM, Ioi Lam wrote:
|Please review a very small fix:||
||
||http://cr.openjdk.java.net/~iklam/8022740/vs2008_ide_001/||
||
||Bug: Visual 2008 IDE build is broken||
||
||http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8022740||
||https://jbs.oracle.com/bugs/browse/JDK-8022740||
||
||Summary of fix:||
||
|| Apparently some refactoring (7163863??) of the VC project
creator has||
|| not been tested with VS2008.||
||
|| I made some minor fixes. I verified that VS2008 works.||
||
|| I changed one file related to VS2010. Could someone with VS2010
give it a try?||
||||
||Thanks||
||- Ioi||
||
|