The changes look good to me. -Chris
> On 4 Oct 2013, at 11:29, Tomas Hurka <tomas.hu...@googlemail.com> wrote: > > Hi Chris, > my use case is integration of Java VisualVM into JDK. > >> On 4 Oct 2013, at 11:42, Chris Hegarty wrote: >> >> The changes look to me. Out of curiosity, what is the use case for zip files? >> >> -Chris >> >>> On 4 Oct 2013, at 10:07, Tomas Hurka <tomas.hu...@googlemail.com> wrote: >>> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8025920 >>> >>> Current version of webrev.ksh provides the diff of the contents of jar >>> file, but it does nothing for zip files. There is a simple fix, which can >>> turn on this functionality for zip files too. See webrev for details. >>> >>> Webrev: <http://cr.openjdk.java.net/~thurka/8025920/webrev/> >>> >>> Thanks in advance for review. > > -- > Tomas Hurka <mailto:tomas.hu...@oracle.com> > NetBeans Profiler http://profiler.netbeans.org > VisualVM http://visualvm.java.net > Software Developer > Oracle, Praha Czech Republic > > >
