Thanks for the review. The fix was pushed to jkd8/build repo. See: <http://hg.openjdk.java.net/jdk8/build/rev/d23177734b28>
On 7 Oct 2013, at 23:57, Mike Duigou wrote: > Looks good to me. Thanks for this contribution! > > Mike > > On Oct 4 2013, at 07:49 , Tomas Hurka wrote: > >> Hi Kumar, >> updated webrev: <http://cr.openjdk.java.net/~thurka/8025920/webrev.01> >> >> On 4 Oct 2013, at 16:08, Kumar Srinivasan wrote: >> >>> Hi Tomas, >>> >>> Looks good!, and thanks for doing this, some minor comments.... >>> >>> There is a typo though. >>> >>> + # It's a JAR or ZIP file, let's do it differntly >>> >>> s/differntly/differently/ >>> >>> 2711 print "No access to jar, so can't produce diffs for >>> jar files" >>> >>> this message should be changed to jar or zip file. >>> >>> Kumar >>> >>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8025920 >>>> >>>> Current version of webrev.ksh provides the diff of the contents of jar >>>> file, but it does nothing for zip files. There is a simple fix, which can >>>> turn on this functionality for zip files too. See webrev for details. >>>> >>>> Webrev: <http://cr.openjdk.java.net/~thurka/8025920/webrev/> >>>> >>>> Thanks in advance for review. >>>> >>>> Bye, >>>> -- >>>> Tomas Hurka <mailto:tomas.hu...@oracle.com> >>>> NetBeans Profiler http://profiler.netbeans.org >>>> VisualVM http://visualvm.java.net >>>> Software Developer >>>> Oracle, Praha Czech Republic >>>> >>> >> >> -- >> Tomas Hurka <mailto:tomas.hu...@oracle.com> >> NetBeans Profiler http://profiler.netbeans.org >> VisualVM http://visualvm.java.net >> Software Developer >> Oracle, Praha Czech Republic >> >> >> > -- Tomas Hurka <mailto:tomas.hu...@oracle.com> NetBeans Profiler http://profiler.netbeans.org VisualVM http://visualvm.java.net Software Developer Oracle, Praha Czech Republic
