Hi Kumar, thanks, that's a good point. I'll incorporate the changes into the webrev.
Regards, Volker On Friday, November 15, 2013, Kumar Srinivasan wrote: > > Hi Volker, > > One thing I notieced, > > BOOT_RTJAR=`$BOOT_JDK/bin/java -XshowSettings 2>&1 ....... > > I suggest using java -XshowSettings:props -version 2>&1 ......... > > props, will narrow down the reporting to only properties section, which is > really what you want > > -version, will allow the launcher to return a 0 exit value, since > -XshowSettings > behaves like -showversion ie. another class or option is expected for the > launcher > to continue. > > Kumar > > > Hi, >> >> could you please review the following small webrev: >> >> http://cr.openjdk.java.net/~simonis/webrevs/8026964/ >> >> It not only fixes bug 8026964 on AIX, but is changes the general way >> of how to compute BOOT_RTJAR. >> >> With the new solution, BOOT_RTJAR is computed right from the system >> property 'sun.boot.class.path'. The new solution should be more robust >> and more portable as it doesn't depend on the name of the jar file >> which contains the boot classes and it also doesn't depend on the fact >> that all these classes are located in a single jar file. >> >> In order to avoid build warnings, I've taken extra care to remove jar >> files and paths from the 'sun.boot.class.path' output which do not >> exist (e.g. jfr.jar is not available in an OpenJDK build but appears >> in 'sun.boot.class.path' anyway - maybe this is another bug that >> should be fixed; also jre/classes appears in 'sun.boot.class.path' >> although it is not present in the file system - maybe we should fix >> that as well). >> >> If we are building on Windows, I convert the content of >> 'sun.boot.class.path' to Unix form to avoid problems with the FIXPATH >> utility. Later, during the build, FIXPATH will convert the path list >> back to Windows form. >> >> I've tested the new Solution on Linux, Windows, Solaris and AIX and >> couldn't find any problems. >> >> I would like to put this into the ppc-aix-port/stage repository but as >> this is a general fix and if you'd like to, it would be also OK if >> you'd push it right to the build repository. >> >> Thank you and best regards, >> Volker >> > >
