On 2013-11-18 22:33, Volker Simonis wrote:
Hi Magnus,

is the msys build currently working (i.e. can I test it out of the box)?
I think otherwise it would be hard to get this right for msys (it took me quite some time to get it right on Cygwin, so without a full sucessfull build I wouldn't bet on it:)

I agree that we shouldnt unnecessarily break the msys build. Actually, I contributed the first msys changes for jdk7:) I'll try to find a solution which works on both systems...

No, I don't think msys currently works out out of the box. There's a silly show-stopper in the configure script, https://bugs.openjdk.java.net/browse/JDK-8022177.

But actually, I'm just proposing that it should fail with style on msys. :-) Something like this would be acceptable to me, given that msys is currently not working anyhow.

if test "x$OPENJDK_BUILD_OS_ENV" = "xwindows.cygwin"; then
  BOOT_RTJAR=`cygpath -u -p "$BOOT_RTJAR" | $TR ':' ';'`
elif test "x$OPENJDK_BUILD_OS_ENV" = "xwindows.msys"; then
AC_MSG_ERROR([BOOT_RTJAR handling is unfortunately not supported on msys yet])
endif

So we at least get a proper error message on msys. Otherwise we will get a weird BOOT_RTJAR path errors down the line which will be hard to track.

/Magnus

Reply via email to