On 2015-02-27 10:49, Magnus Ihse Bursie wrote:
On 2015-02-27 10:43, Magnus Ihse Bursie wrote:
On 2015-02-26 10:25, Erik Joelsson wrote:
Hello Magnus,
Overall looks good. I would prefer if some of the longer lines in
Main.gmk were split as it's a file I often need to read. In
MakeBase, the definition of dups, I thought we (informally) agreed
to start such macro definitions with a newline to make them stand
out more from normal variable declarations?
I had forgot about that; I just copied the pattern of the macros that
was already in place.
I have now updated dups to use the newline format. I also updated the
old macros to follow this rule.
All the new lines in MakeBase should now be shorter than 80 chars.
Not quite 80 (the ### lines are exactly 80) but short enough for my
taste. Thanks!
... and I added the missing targets test-*-jtreg-native to ALL_TARGETS.
It's not important, but I have tended to put the "ALL_TARGETS +=" at the
end of each marked off section so that it is easier to visually verify
that nothing is forgotten. You added all of it to the bottom of "Run
tests". I will let you decide if you think that should be fixed.
/Erik
