On 2015-02-27 10:57, Erik Joelsson wrote:

... and I added the missing targets test-*-jtreg-native to ALL_TARGETS.

It's not important, but I have tended to put the "ALL_TARGETS +=" at the end of each marked off section so that it is easier to visually verify that nothing is forgotten. You added all of it to the bottom of "Run tests". I will let you decide if you think that should be fixed.

It is reasonable. I fixed it as well.

http://cr.openjdk.java.net/~ihse/JDK-8072842-build-native-jtreg-tests/webrev.05

Ok now? :)

/Magnus

Reply via email to