On 11/03/15 07:36, Magnus Ihse Bursie wrote:
It is not very clear that SetupArchive is actually creating a jar file. Analogous with SetupZipArchive, it should be renamed to SetupJarArchive. Also, the implementation should be moved to a separate file, out of JavaCompilation.gmk.Bug: https://bugs.openjdk.java.net/browse/JDK-8141333WebRev: http://cr.openjdk.java.net/~ihse/JDK-8141333-fix-SetupJarArchive/webrev.01
Looks good. /Tim