jdk/make/gendata/GendataPolicyJars.gmk:
You add "include JarArchive.gmk" but didn't remove "include JavaCompilation.gmk".

Otherwise nice.

/Erik

On 2015-11-03 16:36, Magnus Ihse Bursie wrote:
It is not very clear that SetupArchive is actually creating a jar file. Analogous with SetupZipArchive, it should be renamed to SetupJarArchive. Also, the implementation should be moved to a separate file, out of JavaCompilation.gmk.

Bug: https://bugs.openjdk.java.net/browse/JDK-8141333
WebRev: http://cr.openjdk.java.net/~ihse/JDK-8141333-fix-SetupJarArchive/webrev.01

/Magnus


Reply via email to