On 6/11/2015 6:08 PM, Volker Simonis wrote:
On Fri, Nov 6, 2015 at 8:35 AM, David Holmes <david.hol...@oracle.com> wrote:
Hi Magnus,
On 6/11/2015 1:43 AM, Magnus Ihse Bursie wrote:
Unfortunately, the --disable-warnings-as-errors flag only operates on
the build-infra code, and does not propagate to the Hotspot build system.
This is unfortunate, and also very confusing for users who think they
have disabled warnings as errors, only to get an error in the hotspot
build instead.
We should set the correct value for hotspot makefiles from configure as
well.
Bug: https://bugs.openjdk.java.net/browse/JDK-8141543
WebRev:
http://cr.openjdk.java.net/~ihse/JDK-8141543-propagate-disable-warnings-as-errors-to-hotspot/webrev.01
You are setting WARNINGS_AS_ERRORS but hotspot uses WARNINGS_ARE_ERRORS.
David,
WARNINGS_AS_ERRORS is only the name of the top-level configure
variable. But the actual export to the hotspot build is
WARNINGS_ARE_ERRORS:
HOTSPOT_SET_WARNINGS_AS_ERRORS=WARNINGS_ARE_ERRORS=
I looked at that many times and still did not see it :(
Really doesn't make sense to have two different words being used.
Thanks,
David
Regards,
Volker
David
/Magnus
