Thank you for review.
Leonid
On 05.05.2016 00:42, David Holmes wrote:
On 5/05/2016 12:10 AM, Leonid Mesnik wrote:
The hotspot changes are fixed separately and the final fix is only
changes in the root. It remains the same.
http://cr.openjdk.java.net/~lmesnik/8155950/webrev.00/root/
<http://cr.openjdk.java.net/%7Elmesnik/8155950/webrev.00/root/>
Ok.
Thanks,
David
Leonid
On 04.05.2016 13:23, David Holmes wrote:
On 4/05/2016 7:01 PM, Leonid Mesnik wrote:
David
On 04.05.2016 11:40, David Holmes wrote:
On 4/05/2016 4:43 PM, Leonid Mesnik wrote:
Please review this small change which adds minimal VM as a part of
default JIB profile on linux-x86. The fix also include quick
workaround
for bug JDK-8155946
<https://bugs.openjdk.java.net/browse/JDK-8155946>.
Bug: https://bugs.openjdk.java.net/browse/JDK-8155950
Webrev (top):
http://cr.openjdk.java.net/~lmesnik/8155950/webrev.00/root/
<http://cr.openjdk.java.net/%7Elmesnik/8155950/webrev.00/root/>
I thought we should only be building minimal and server now?
The client removal is covered by separate issue:
8154209: Remove client VM from default JIB profile on windows-x86 and
linux-x86
The fix is ready (thanks to Mikael) however install bug JDK-8154410
jdk9 windows-i586 build fails on setting "--with-jvm-variants=server"
<https://bugs.openjdk.java.net/browse/JDK-8154410>
is a blocker. So the plan is to push it later after JDK-8154410 is
fixed
or RE confirm that it is not a blocker anymore.
Okay I suppose - seems like an awful lot of overhead to touch this
code multiple times.
Webrev(hotspot):
http://cr.openjdk.java.net/~lmesnik/8155950/webrev.00/hotspot/
<http://cr.openjdk.java.net/%7Elmesnik/8155950/webrev.00/hotspot/>
This needs a separate CR. I don't know how this breakage slipped in
but it is a distinct issue.
Ok, I will get a fix of JDK-8155946 first then and push only build
changes in this fix.
OK. They can both be pushed together - just two separate changesets.
Thanks,
David
Leonid
Thanks,
David
Testing: JPRT (with updated testing of minimal VM flags)
Leonid
