Hi David, On Mon, Dec 19, 2016 at 11:35 AM, David Holmes <david.hol...@oracle.com> wrote:
> Hi Thomas, > > On 19/12/2016 8:15 PM, Thomas Stüfe wrote: > >> Hi all, >> >> What is the correct version of the autoconf tools to use when regenerating >> generated-configure.sh? >> > > Current checked-in hs and dev versions says > > # Generated by GNU Autoconf 2.69 for OpenJDK jdk9. > > > I am generating with autoconf 2.69 and get a number of diffs unrelated to >> my change, among others: >> >> + -runstatedir | --runstatedir | --runstatedi | --runstated \ >> + | --runstate | --runstat | --runsta | --runst | --runs \ >> >> etc. I see option runstatedir has been removed in "8166937: [Solaris] >> Missing libjvm_db.so and libjvm_dtrace.so from JDK 9 b138". Was that >> delibarate? Am I using the wrong autoconf? >> >> Or, asked another way, should I even care? When providing webrevs for >> changes in m4 files, should I also provide an updated configure script? >> And >> if yes, should it only diff minimally? >> > > You should include it in the webrev simply because it will be there > anyway. But I never review it, only the .m4 changes. > > Good to know. > David > Thanks! Thomas > > Thank you! >> >> Thomas >> >>
