Hi Volker, On Mon, Dec 19, 2016 at 11:35 AM, Volker Simonis <[email protected]> wrote:
> I think it's still 2.69 - at least that's what generated-configure.sh > pretends: > > #! /bin/sh > # Guess values for system-dependent variables and create Makefiles. > # Generated by GNU Autoconf 2.69 for OpenJDK jdk9. > > In general you don't have to really care because it has to be > re-generated on Oracle's side anyway. But I think providing a version > of generated-configure.sh within the webrev is just a convenience for > reviewers (and a double-check for you). > > Thanks! > I'm actually not sure why you get unrelated changes in the file when > using autoconf 2.69? > I think I just used a too modern variant of autoconf. It introduced into configure.sh the --runstatedir option, which autoconf 2.69 does not yet have. > > Regards, > Volker > > > Thanks, Thomas > On Mon, Dec 19, 2016 at 11:15 AM, Thomas Stüfe <[email protected]> > wrote: > > Hi all, > > > > What is the correct version of the autoconf tools to use when > regenerating > > generated-configure.sh? > > > > I am generating with autoconf 2.69 and get a number of diffs unrelated to > > my change, among others: > > > > + -runstatedir | --runstatedir | --runstatedi | --runstated \ > > + | --runstate | --runstat | --runsta | --runst | --runs \ > > > > etc. I see option runstatedir has been removed in "8166937: [Solaris] > > Missing libjvm_db.so and libjvm_dtrace.so from JDK 9 b138". Was that > > delibarate? Am I using the wrong autoconf? > > > > Or, asked another way, should I even care? When providing webrevs for > > changes in m4 files, should I also provide an updated configure script? > And > > if yes, should it only diff minimally? > > > > Thank you! > > > > Thomas >
