Looks good.
Nit: Javadoc.gmk:358-360 only indented 2 spaces for continuation. Same
goes for 390-393, but you didn't actually touch those lines.
/Erik
On 2017-04-19 14:36, Magnus Ihse Bursie wrote:
This patch will solve three issues that I (unfortunately) filed as
separate issues, but that shares a common solution. The three issues are:
JDK-8178038 Copy jdwp-protocol.html to proper location
JDK-8178039 Copy jvmti.html to proper location
JDK-8178316 Add JVM-MANAGEMENT-MIB.mib to
jdk/src/java.management/share/specs/
This patch will also solve this in a general way, to start preparing
for JDK-8177434 (Copy specifications from module specs directory to
docs image).
Bug descriptions:
https://bugs.openjdk.java.net/browse/JDK-8178038 Copy
jdwp-protocol.html to proper location
After JDK-8172312, the copy of jvmti.html into docs/platform/jvmti
will stick out like a sore thumb. It should be moved to the new
location designed by JEP 299, in docs/specs.
https://bugs.openjdk.java.net/browse/JDK-8178039 Copy jvmti.html to
proper location
After JDK-8172312, the copy of jvmti.html into docs/platform/jvmti
will stick out like a sore thumb. It should be moved to the new
location designed by JEP 299, in docs/specs.
https://bugs.openjdk.java.net/browse/JDK-8178316 Add
JVM-MANAGEMENT-MIB.mib to jdk/src/java.management/share/specs/
The file JVM-MANAGEMENT-MIB.mib have unfortunately been stored in the
closed sources. This was an oversight, and it should be moved to open
sources.
The file will follow the new structure of JEP 299 and be put in
java.management/share/specs/, and copied to docs/specs during build.
WebRev:
http://cr.openjdk.java.net/~ihse/JDK-8178038-javadoc-specs/webrev.01
/Magnus
