As long as pandoc for windows is always a windows native thing and not provided by cygwin this seems good. A quick googling indicates that cygwin currently does not provide pandoc so should be fine then.

/Erik


On 2017-05-18 09:27, Magnus Ihse Bursie wrote:
Looks good. Formally, I believe someone else needs to review it.

/Magnus

On 2017-05-18 02:07, Brad R. Wetmore wrote:
Magnus,

I've added your suggested fix to spec.gmk.in, which is the minor tweak to add @FIXPATH@ to allow pandoc to run on windows builds.

    https://bugs.openjdk.java.net/browse/JDK-8180540
    http://cr.openjdk.java.net/~wetmore/8180540/webrev.00/

I put you down as Contributed-by: with myself as reviewer, but thought you (and others?) might want to at least check it.

Thanks,

Brad


Reply via email to