Hi Adrian, Changes look fine to me. I cannot build and test though, do not have a sparc linux machine.
Kind Regards, Thomas On Tue, Jul 4, 2017 at 11:33 AM, John Paul Adrian Glaubitz < glaub...@physik.fu-berlin.de> wrote: > On Wed, Jun 14, 2017 at 01:50:06PM +0200, Erik Helin wrote: > > I think the first three patches (hotspot-add-missing-log-header.diff, > > hotspot-fix-checkbytebuffer.diff, rename-sparc-linux-atomic-header.diff) > all > > look good, thanks for fixing broken code. Consider them Reviewed by me. > > Every patch needs a corresponding issue in the bug tracker, so I went > ahead > > and created: > > - https://bugs.openjdk.java.net/browse/JDK-8182163 > > - https://bugs.openjdk.java.net/browse/JDK-8182164 > > - https://bugs.openjdk.java.net/browse/JDK-8182165 > > Any chance a second maintainer can review those? > > I have run the test suite as mentioned before: > > > https://people.debian.org/~glaubitz/openjdk-9_9~b170-2_ > sparc64.new.build.gz > > Thanks, > Adrian > > -- > .''`. John Paul Adrian Glaubitz > : :' : Debian Developer - glaub...@debian.org > `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de > `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913 >
