On 07/04/2017 11:33 AM, John Paul Adrian Glaubitz wrote:
On Wed, Jun 14, 2017 at 01:50:06PM +0200, Erik Helin wrote:
I think the first three patches (hotspot-add-missing-log-header.diff,
hotspot-fix-checkbytebuffer.diff, rename-sparc-linux-atomic-header.diff) all
look good, thanks for fixing broken code. Consider them Reviewed by me.
Every patch needs a corresponding issue in the bug tracker, so I went ahead
and created:
- https://bugs.openjdk.java.net/browse/JDK-8182163
- https://bugs.openjdk.java.net/browse/JDK-8182164
- https://bugs.openjdk.java.net/browse/JDK-8182165
Any chance a second maintainer can review those?
I have run the test suite as mentioned before:
https://people.debian.org/~glaubitz/openjdk-9_9~b170-2_sparc64.new.build.gz
Although these three patches are correct, it seems like you have some
way to go still to make this port solid :) All tests (that are
applicable) in hotspot_tier1 should pass (besides the ones in
ProblemList.txt). If you run the test via the top-level Makefiles, as in:
$ make test TEST=hotspot_tier1
then all tests should pass (because the Makefiles will pass
ProblemList.txt to jtreg). After you get the code to compile, this
should be your next goal :)
Thanks,
Erik
Thanks,
Adrian
