On 03/24/2018 02:26 AM, Magnus Ihse Bursie wrote: > > On 2018-03-20 14:54, Edward Nevill wrote: >> Thanks for this. I have updated the webrev with the above comment. >> >> http://cr.openjdk.java.net/~enevill/8199138/webrev.01 > I note that in platform.m4 (sorry I didn't say this earlier), you set the > CPU_ARCH to riscv64 as well, and not just riscv. Now I don't know how likely > it is > that OpenJDK will ever support the 32-bit version of riscv, but it seems like > it would make more sense to define the CPU_ARCH as "riscv", and the CPU as > "riscv64". > > It's just a minor thing, if you like it the way it is, keep it.
I agree, this is a bit odd. @Edward: Is this correct as it currently is? Would be great if this changeset could finally get merged as Debian just recently bootstrapped riscv64 and is now building packages on real hardware with 10 build machines running: > https://buildd.debian.org/status/architecture.php?a=riscv64&suite=sid I assume the build dependencies for OpenJDK in Debian will be built in around a week or so. Until I then, we should have sorted this patch out so I can add a (backported) patch to Debian's openjdk-8/9/10/11 packages. Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
