On Tue, 2018-03-27 at 17:46 +0900, John Paul Adrian Glaubitz wrote:
> On 03/27/2018 05:23 PM, Edward Nevill wrote:
> > @@ -1733,6 +1733,9 @@
> > #ifndef EM_AARCH64
> > #define EM_AARCH64 183 /* ARM AARCH64 */
> > #endif
> > +#ifndef EM_RISCV /* RISCV */
> > + #define EM_RISCV 243
> > +#endif
>
> What confuses me: Why RISCV here and not RISCV64?
>
> In particular this hunk:
>
> @@ -1758,6 +1761,7 @@
> {EM_PARISC, EM_PARISC, ELFCLASS32, ELFDATA2MSB,
> (char*)"PARISC"},
> {EM_68K, EM_68K, ELFCLASS32, ELFDATA2MSB,
> (char*)"M68k"},
> {EM_AARCH64, EM_AARCH64, ELFCLASS64, ELFDATA2LSB,
> (char*)"AARCH64"},
> + {EM_RISCV, EM_RISCV, ELFCLASS64, ELFDATA2LSB,
> (char*)"RISCV"},
> };
>
> I know there is already 32-bit RISC-V and there are actually plans
> for
> using it. So, it looks to me you would be breaking 32-bit RISC-V
> here.
>
Because that is what is defined in elf.h
>From /usr/include/elf.h
#define EM_RISCV 243 /* RISC-V */
There is no EM_RISCV32 or EM_RISCV64 in elf.h
All the best,
Ed.
