Hi Misha, This looks good, thanks for doing this.
Thanks, Christia > On Mar 29, 2018, at 10:41 04PM, Mikhailo Seledtsov > <mikhailo.seledt...@oracle.com> wrote: > > While testing I discovered build errors on Mac and Solaris. The following > statement " BUILD_HOTSPOT_JTREG_EXECUTABLES_LIBS_exesigtest := -ljvm" was > added to a Linux-only block. I have updated the make file to add this for any > platform w/o conditions; the " exesigtest.c" is excluded from Windows anyway > down below in the make file. I am not 100% sure this is the correct way to > modify the make file; if not please advise the correct way. > With this fix all 4 builds pass. > > Here is the updated webrev: > http://cr.openjdk.java.net/~mseledtsov/8200126.02.open/index.html > > Thank you, > Misha > > > On 3/29/18, 4:00 PM, mikhailo wrote: >> I have addressed feedback from Christian, David and Magnus. Here is the >> updated webrev: >> >> http://cr.openjdk.java.net/~mseledtsov/8200126.01.open/index.html >> >> >> I have also confirmed that output from exesigtest.c printf() is logged into >> .jtr files. >> >> Grepped for "signal", I can see the output such as: >> TestSigxfsz.jtr:SIGXFSZ: signal handler using function 'sigset' has >> been set >> TestSigxfsz.jtr:SIGXFSZ: signal handler for signal 25 has been >> processed >> TestSigxfsz.jtr:SIGXFSZ: signal has been sent successfully >> TestSigxfsz.jtr:SIGXFSZ: signal has been received >> Also can see other output from the printf, such as all initVM logs. >> >> >> Thank you, >> Misha >> >> On 03/29/2018 02:49 PM, mikhailo wrote: >>> Magnus, >>> >>> Thank you for advice. I have updated the makefile accordingly. Will post >>> updated webrev shortly. >>> >>> >>> Misha >>> >>> >>> On 03/28/2018 03:26 PM, Magnus Ihse Bursie wrote: >>>> Yes, you seem to have based this off an old version of >>>> JtregNativeHotspot.gmk. >>>> >>>> If you update the file I think you see how you should do it, but I'll give >>>> you some help: >>>> >>>> ifeq ($(OPENJDK_TARGET_OS), windows) >>>> BUILD_HOTSPOT_JTREG_EXECUTABLES_CFLAGS_exeFPRegs := -MT >>>> BUILD_HOTSPOT_JTREG_EXCLUDE += exesigtest.c >>>> endif >>> >>
