Hi Alexey, looks good to me (not a Reviewer however). Thanks, Matthias
> -----Original Message----- > From: Alexey Ivanov [mailto:alexey.iva...@oracle.com] > Sent: Mittwoch, 2. Mai 2018 11:52 > To: 2d-dev <2d-...@openjdk.java.net> > Cc: build-dev <build-dev@openjdk.java.net>; Baesken, Matthias > <matthias.baes...@sap.com> > Subject: [11] RFR for JDK-8202476: ImageLib is broken in 32 bit Windows > > Hi, > > Could you please review the following fix for jdk11? > > bug: https://bugs.openjdk.java.net/browse/JDK-8202476 > webrev: http://cr.openjdk.java.net/~aivanov/8202476/jdk11/webrev.0/ > > This is a follow-up fix for JDK-8201226 which enabled building JDK for > 32 bit Windows, its code review: > http://mail.openjdk.java.net/pipermail/build-dev/2018-April/021553.html > > I found this issue: > http://mail.openjdk.java.net/pipermail/2d-dev/2018-April/009150.html > > > This fix removes JNICALL modifiers from exported functions in medialib. > After the fix, the failing tests in test/jdk/java/awt/image pass. > > > Thank you in advance. > > Regards, > Alexey
